search

carbon-design-system / carbon-components-vue

Vue implementation of the Carbon Design System
http://vue.carbondesignsystem.com
Apache License 2.0
608 stars 180 forks source link

fix: dropdown menu fix for accessability announcement #1619

Closed davidnixon closed 3 months ago

davidnixon commented 3 months ago

What did you do?

Correct accessibility issue with dropdown menu. Invalid text and warning text were not being announced in screen reader.

Why did you do it?

Found during development by Alessio Mantegna. Fix also provided by Alessio.

How have you tested it?

With screen reader in Safari. Easiest place to test is with the slots story http://localhost:6006/?path=/story/component-cvdropdown--slots There you can toggle the warning and invalid slots and confirm they are announced.

Were docs updated if needed?

davidnixon commented 3 months ago

Approved by Alessio, accessibility focal on my team.