search

carbon-design-system / carbon-icons

SVG icon library for the Carbon Design System
https://www.carbondesignsystem.com/guidelines/iconography/library
Apache License 2.0
85 stars 53 forks source link

Contribution: Mobile #105

Open kaylarakower opened 5 years ago

kaylarakower commented 5 years ago

1. DrupalOne

2. Mobile

3. Please see the description in the following note: https://ibm.box.com/s/lzhulkf3tdxsvkkiy0utnd400d8xbdyg

4. https://ibm.box.com/s/arn1ri3f3ksvi2ooitrdw6933h3gsdgc

5.

Screen Shot 2019-05-22 at 4 28 46 PM

conradennis commented 5 years ago

Hi @kaylarakower thanks for your submission. A couple notes: we draw all of our icons at 32px in Illustrator and only create bespoke icons at other sizes when absolutely necessary. Agreed that we should add a tablet icon to the library and that the mobile icon's proportions are more tablet-like. The reason being that our mobile icons have to accommodate modifiers as shown below

Screen Shot 2019-05-23 at 10 26 11 AM

I'll take a look at the existing icon set and see if we can finesse the form a bit to better represent an actual mobile device. As for tablet issue #104 I think it would be best represented in landscape as that's typically how a tablet is held and it would create a better distinction between "mobile" and "tablet"

Screen Shot 2019-05-23 at 10 40 42 AM

kaylarakower commented 5 years ago

Hey @conradennis, Do we have research to reference that says users typically work in landscape on a tablet? If so, I will make some changes to the design that the icon is going to represent. With that said, when the icons are side by side and then next to the desktop icon, do you think users may think that if we show tablet in a landscape view, they may confuse this with a mobile landscape view?

shixiedesign commented 5 years ago

This is interesting coz I made a batch of icons for 4 devices awhile back. I'm not precious about these and feel free to ignore them. Here's the AI file if you are interested in including a few more devices while you are at it:

https://ibm.box.com/s/014ykoj4io54ljy00axmg3i0ztvt84zg

image

conradennis commented 5 years ago

@shixiedesign sweet thank you! to your point @kaylarakower I was thinking of making mobile and tablet icons a bit more distinct to avoid confusion. possibly something like this:

Screen Shot 2019-05-23 at 11 13 27 AM

will look these over with Mike as a set next week and will let you know when we come to a conclusion

conradennis commented 5 years ago

@shixiedesign lol your link expired. I have a fix for that, you can change the expiration date on shared links

Screen Shot 2019-05-23 at 11 17 02 AM
shixiedesign commented 5 years ago

@conradennis oops sorry! Just fixed. try again!

kaylarakower commented 5 years ago

@conradennis Looking forward to hearing about what you and Mike decide on! One comment on the illustrations though- I'm not sure if removing the line at the bottom will help differentiate the two, but thats just an opinion :)

conradennis commented 5 years ago

@kaylarakower just looked everything over with Mike and this is the direction we're going:

Screen Shot 2019-05-29 at 10 39 13 AM

kaylarakower commented 5 years ago

@conradennis can you please email me the svgs? kayla.rakower@ibm.com

mjabbink commented 4 years ago

@conradennis should this close?