carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System
https://carbon-design-system.github.io/carbon-react-native/
Apache License 2.0
30 stars 8 forks source link

Table Cell-Section (FormItem type="header") missing variations #110

Closed ebQWlN5HBDsKVbhnsd5QJMZRshJUyuFm8U3OEwL closed 1 year ago

ebQWlN5HBDsKVbhnsd5QJMZRshJUyuFm8U3OEwL commented 1 year ago

In the Gray 10 Theme Mobile-Carbon Design System figma file there is a component called TableCell- Section. Design here: https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(WIP)-Gray-10-Theme-Mobile---Carbon-Design-System?node-id=14455-242397&t=6RHKVeicjb3qUDHv-4

We think we can render this using a FormItem with the type "header" however there are three variations that are missing to align with the figma Table Cell-Section design:

Missing compact version header-compact

Missing the description variant header-description

Missing the variation with the description at the top and then the title at the bottom (the stacked variant) header-stacked

Can we update the FormItem type="header" to render these additional variations? If there is another way to render these variations that we are not aware of please let us know.

If you have design questions you can slack @LISA or @rjgervacio If you need any additional information you can slack @Ann-Marie Kemp

@David-Bradshaw

WYXEhlEtzb2Gfe6HgrQLAf6MeMEatE77yYzHHIH commented 1 year ago

FormItem changes:

Examples of each:

Screenshot 2023-04-11 at 2 45 08 PM Screenshot 2023-04-11 at 2 45 00 PM Screenshot 2023-04-11 at 2 44 44 PM Screenshot 2023-04-11 at 2 44 37 PM Screenshot 2023-04-11 at 2 44 24 PM Screenshot 2023-04-11 at 2 44 17 PM Screenshot 2023-04-11 at 2 41 34 PM

WYXEhlEtzb2Gfe6HgrQLAf6MeMEatE77yYzHHIH commented 1 year ago

Released in 0.3.1

🔗 https://na.artifactory.swg-devops.com/artifactory/api/npm/hyc-aspera-ui-team-npm-local/package/carbon-react-native 🔗 https://github.ibm.com/Aspera/carbon-react-native/releases/tag/v0.3.1