carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System
https://carbon-design-system.github.io/carbon-react-native/
Apache License 2.0
30 stars 8 forks source link

Tooltip icon color #114

Closed ebQWlN5HBDsKVbhnsd5QJMZRshJUyuFm8U3OEwL closed 1 year ago

ebQWlN5HBDsKVbhnsd5QJMZRshJUyuFm8U3OEwL commented 1 year ago

In the Gray 10 Theme Mobile-Carbon Design System figma file there is a component called Tooltip. Design here: https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(WIP)-Gray-10-Theme-Mobile---Carbon-Design-System?node-id=1880-7393&t=pExk7dwH4TEEmGNT-4

Icon should be black when the content is open and visible

tooltip-color

Icon should be greyed out a bit when content is closed and non visible

visible-non-visible

we think the icon is rendering blue from the button style which is influencing the icon color. Design is using an icon but library is using a button, a suggestion from on of our devs: if you could make the trigger a slot that may fix the issue

If you have design questions you can slack @LISA or @rjgervacio If you need any additional information you can slack @kwadwo

@David-Bradshaw

dabrad26 commented 1 year ago

Added for iconOnly buttons (which is just the icon version only).

Looked into definition tooltips but iOS does not have support for dashed borders and underlines cannot be colored. Seems small and no requests yet. So will skip for now and if a team needs we can draw the line manually.

https://stackoverflow.com/questions/73506925/when-trying-to-add-a-dashed-border-style-getting-unsupported-dashed-dotted-b

Screenshot 2023-09-19 at 10 50 41 Screenshot 2023-09-19 at 10 50 45