carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System
https://carbon-design-system.github.io/carbon-react-native/
Apache License 2.0
30 stars 8 forks source link

Menu updates to match design #115

Closed ebQWlN5HBDsKVbhnsd5QJMZRshJUyuFm8U3OEwL closed 1 year ago

ebQWlN5HBDsKVbhnsd5QJMZRshJUyuFm8U3OEwL commented 1 year ago

In the Gray 10 Theme Mobile-Carbon Design System figma file there is a component called Menu. Design here: https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(WIP)-Gray-10-Theme-Mobile---Carbon-Design-System?node-id=12846-269886&t=pExk7dwH4TEEmGNT-4

missing drop shadow around menu box:

menu-dropshadow

can’t put icons to the left right now

menu-item-left-icon

If you have design questions you can slack @LISA or @rjgervacio If you need any additional information you can slack @kwadwo

@David-Bradshaw

dabrad26 commented 1 year ago

Added: Screenshot 2023-09-19 at 11 29 35 Screenshot 2023-09-19 at 11 29 30

To use:

on MenuItem set icon to a Carbon Icon. You can override the color via iconColor. If iconColor not set the icon will follow standard rules.

The DropdownItem supports the same props (Dropdown uses Menu under the hood).

maxMenuHeight is now a prop for both Menu and Dropdown.