carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System
https://carbon-design-system.github.io/carbon-react-native/
Apache License 2.0
30 stars 8 forks source link

Notification component needs updates to match design #124

Closed YtgmHAdHsvxfjyRYW53Y9kA9JHUKpEaKjkHs8Oy closed 1 year ago

YtgmHAdHsvxfjyRYW53Y9kA9JHUKpEaKjkHs8Oy commented 1 year ago

In the Gray 10 Theme Mobile-Carbon Design System figma file there is a component called Notification. Design here: https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(Beta)-Gray-10-Theme-Mobile---Carbon-Design-System?type=design&node-id=1880-5505&t=8njoXVhePM30Alif-4

f2726a18-c0a8-44d3-9422-cd5630e55cb9

0aec26a6-7a7f-4c48-8bf3-36ea584418e4

3ee3071c-4c81-4c1f-8e27-3b797122d22f

If there is another way to render these items that we are not aware of please let us know. Thank you

dabrad26 commented 1 year ago

Button now supports high-contrast and high-contrast-inverse. These can be used with some extra work

<Button forceTheme={lowContrast ? 'light' : undefined} kind={lowContrast ? 'high-contrast' : 'high-contrast-inverse'} style={this.styles.button} onPress={this.actionCallback} text="Action" />

This has been added to the documentation for the Notification component. This is needed since Theme manager doesn't handle layers like Notification rendering in light mode in Dark theme with its custom colors.

dabrad26 commented 1 year ago

Example:

Untitled5

dabrad26 commented 1 year ago

Drop shadow can be turned on via new prop dropShadow (Boolean). This is off by default.