search

carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System
https://carbon-design-system.github.io/carbon-react-native/
Apache License 2.0
30 stars 8 forks source link

Beta Gray 10 Theme - Menu component #131

Closed OvZwU32sfuriP5Ph8mtbO9kjEXUJUSRhzBelnuz closed 1 year ago

OvZwU32sfuriP5Ph8mtbO9kjEXUJUSRhzBelnuz commented 1 year ago

In the Beta Gray 10 Theme Mobile-Carbon Design System Figma file, the "Menu" component needs the divider boolean, full-width option. Design here: https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(Beta)-Gray-10-Theme-Mobile---Carbon-Design-System?type=design&node-id=12846-269886&mode=design&t=RtDwhtY0ecsxTpjy-4

OvZwU32sfuriP5Ph8mtbO9kjEXUJUSRhzBelnuz commented 1 year ago

Screenshot 2023-07-11 at 3 18 26 PM

dabrad26 commented 1 year ago

Added divider boolean to MenuItem and DropdownItem. Full width is already there; it is up to consumer to not wrap it in padding. For our test app all items have wrapping. Screenshot 2023-09-19 at 12 25 51