[Design review] Text area

carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System

https://carbon-design-system.github.io/carbon-react-native/

Apache License 2.0

30 stars 8 forks source link

[Design review] Text area #32

Closed 8OYx4JT4MsadkJ5CPwN52Fdm7fbRLSNYd0h4y5I closed 2 years ago

8OYx4JT4MsadkJ5CPwN52Fdm7fbRLSNYd0h4y5I commented 2 years ago

[x] Vertical padding in build doesn't match the designs (see the image). That could be due to the fact that Text Area uses different font style body-02 – bigger line-height and the top and bottom paddings are 12px.
[x] Can you make the default height of the text area bigger - 144px, basically vertical paddings 12px + 5 lines of text.
[ ] Text area should have a character counter, but this can come later if we are focusing now on design specification.

WYXEhlEtzb2Gfe6HgrQLAf6MeMEatE77yYzHHIH commented 2 years ago

Added:

default height 144
paddingTop = 12, paddingBottom = 12
body-02 used for textarea.

Screen Shot 2022-08-12 at 3 59 37 PM

WYXEhlEtzb2Gfe6HgrQLAf6MeMEatE77yYzHHIH commented 2 years ago

@Mariusz-Mickiewicz these tickets will close once the PR to fix is in. However; if from the screenshots or additional testing something is not covered please feel free to reopen the ticket with the issue and can look more.