carbon-design-system / carbon-react-native

The React Native implementation of the Carbon Design System
https://carbon-design-system.github.io/carbon-react-native/
Apache License 2.0
30 stars 8 forks source link

[Design review] Notification #88

Closed 8OYx4JT4MsadkJ5CPwN52Fdm7fbRLSNYd0h4y5I closed 1 year ago

8OYx4JT4MsadkJ5CPwN52Fdm7fbRLSNYd0h4y5I commented 2 years ago

image

CY1FXz75x1YZoF5iScZcylWTjPMEV1XeqPWVASf commented 2 years ago

@Mariusz-Mickiewicz that ghost button text should use the $link-inverse token so it has contrast accessibility. It will actually be blue 40 ... right now it looks like it's still blue 60

image
WYXEhlEtzb2Gfe6HgrQLAf6MeMEatE77yYzHHIH commented 1 year ago

Changed to button and color linkInverse.

Because it is now a ghost button it has top padding pushing it down

Screen Shot 2022-12-13 at 1 27 41 PM Screen Shot 2022-12-13 at 1 27 51 PM

WYXEhlEtzb2Gfe6HgrQLAf6MeMEatE77yYzHHIH commented 1 year ago

To note the Action is not defined but the component and is just whatever the user passes in. So only change was to the Example/Test app. not the library.