search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.75k stars 1.8k forks source link

[Combo box] all themes hover & select style wrong #3204

Closed shixiedesign closed 4 years ago

shixiedesign commented 5 years ago

Noticed in vanilla, double checked in react:

All theme's hover & select styling on the dropdown is wrong.

Hovered option background be using color token $hover-ui Selected option background should be using color token $selected-ui Selected options border bottom should be using color token $active-ui

image

image

abbeyhrt commented 4 years ago

@aagonzales I believe that the styles for this are coming from the ListBox, which we use for MultiSelect and Dropdown, do you know if those components have the wrong colors too?

laurenmrice commented 4 years ago

in the latest pr i reviewed https://github.com/carbon-design-system/carbon/pull/4753#event-2952626553 these seemed to be correct

On the current live react link the colors are wrong.

tw15egan commented 4 years ago

The deployed version may not be updated as of yet? Not sure how often we update it

abbeyhrt commented 4 years ago

@laurenmrice thank you for looking into it! That PR should be included in the next minor release so if it's alright with you, we can close this issue?

laurenmrice commented 4 years ago

yeah i think this is fine to be closed ! i think its been resolved