search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.87k stars 1.82k forks source link

Revert `@ibm/plex` peerDependency requirement #620

Closed joshblack closed 6 years ago

joshblack commented 6 years ago

We introduced @ibm/plex in a recent release which caused a lot of our production services to miss out on the Plex styles we introduced in our v8 release. This issue is to revert this added peerDependency in a patch release so that we're no longer breaking these services. This peerDependency should be included in a future major release.

monte-hayward commented 6 years ago

hi @joshblack would this fix an issue like the following?

{
  "status": 1,
  "file": "/path/my-project/node_modules/carbon-components/scss/globals/scss/_css--plex-core.scss",
  "line": 4,
  "column": 1,
  "message": "File to import not found or unreadable: @ibm/plex/scss/mono/italic/index.\nParent style sheet: /path/my-project/node_modules/carbon-components/scss/globals/scss/_css--plex-core.scss",
  "formatted": "Error: File to import not found or unreadable: @ibm/plex/scss/mono/italic/index.\n       Parent style sheet: /path/my-project/node_modules/carbon-components/scss/globals/scss/_css--plex-core.scss\n        on line 4 of node_modules/carbon-components/scss/globals/scss/_css--plex-core.scss\n>> @import '@ibm/plex/scss/mono/italic/index';\n   ^\n"
}
joshblack commented 6 years ago

Hi @monte-hayward, yes it should revert back the @ibm/plex changes which are causing this. Sorry about the issue you ran into!