carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
98 stars 138 forks source link

Datagrid "unselect all" checkbox and toolbar action are not working on paged rows #5508

Closed SantoshS333 closed 2 months ago

SantoshS333 commented 5 months ago

Package

Carbon for IBM Products

Description

If the Datagrid has multiple pages, checking the "unselect all" checkbox only unselects the particular page records but doesn't unselect other page records

https://github.com/carbon-design-system/ibm-products/assets/172751750/573199e1-ceb1-4a1c-b504-3ca4c1ccce6c

Component(s) impacted

Additional information

Issue can be simulated on this story https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-datagrid-rowactionbuttons--row-action-buttons-batch-actions-usage-story

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

v2.40.0

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Product/offering

Envizi ESG

CodeSandbox or Stackblitz example

https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-datagrid-rowactionbuttons--row-action-buttons-batch-actions-usage-story&globals=viewport:basic

Steps to reproduce the issue (if applicable)

Populate a datagrid with records that will be paginated Check the "select all" checkbox on the header row Uncheck the "select all" checkbox on the header row

Release date (if applicable)

No response

Code of Conduct

sangeethababu9223 commented 2 months ago

Hi @SantoshS333 , The intended behaviour of select all is to select the current page as per the usage guidelines which is fixed the in the PR: https://github.com/carbon-design-system/ibm-products/pull/5933. So you can implement batch actions and from there you could both select items in all pages using the select all button and deselect all using cancel button.