carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
98 stars 138 forks source link

fix(side panel): slideIn not working as expected in Storybook #6501

Closed sangeethababu9223 closed 3 days ago

sangeethababu9223 commented 4 days ago

Closes #6480

The SlideIn option is not working as expected. Its behavior is currently identical to that of the SlideOver option, which should not be the case.

What did you change?

The issue was with storybook styling. I referred web components package to update the style and HTML in SlideIn Template in SidePanel.stories.jsx

How did you test and verify your work?

Storybook

netlify[bot] commented 4 days ago

Deploy Preview for ibm-products-web-components ready!

Name Link
Latest commit 0ce441f7c435c838bc27e847465eea1575e9734e
Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67459fd2d28848000833a0cc
Deploy Preview https://deploy-preview-6501--ibm-products-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 days ago

Deploy Preview for carbon-for-ibm-products ready!

Name Link
Latest commit 0ce441f7c435c838bc27e847465eea1575e9734e
Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67459fd273840200081c80ce
Deploy Preview https://deploy-preview-6501--carbon-for-ibm-products.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.84%. Comparing base (1d049e0) to head (0ce441f). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6501 +/- ## ======================================= Coverage 79.83% 79.84% ======================================= Files 394 394 Lines 12872 12872 Branches 4257 4257 ======================================= + Hits 10277 10278 +1 + Misses 2595 2594 -1 ``` | [Components](https://app.codecov.io/gh/carbon-design-system/ibm-products/pull/6501/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=carbon-design-system) | Coverage Ξ” | | |---|---|---| | [ibm-products](https://app.codecov.io/gh/carbon-design-system/ibm-products/pull/6501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=carbon-design-system) | `βˆ… <ΓΈ> (βˆ…)` | | | [ibm-products-web-components](https://app.codecov.io/gh/carbon-design-system/ibm-products/pull/6501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=carbon-design-system) | `βˆ… <ΓΈ> (βˆ…)` | |