search

cargomedia / bipbip

UNMAINTAINED. Gather services data and store in CopperEgg/IDERA
MIT License
4 stars 7 forks source link

BO-82 [socket-redis] add token authentication for status end-point #175

Closed kris-lab closed 7 years ago

kris-lab commented 7 years ago

Part of https://github.com/cargomedia/puppet-cargomedia/issues/1702 Depends on https://github.com/cargomedia/socket-redis/pull/97

kris-lab commented 7 years ago

@tomaszdurka @vogdb please have a look

vogdb commented 7 years ago

looks fine to me. Travis failed somehow

tomaszdurka commented 7 years ago

@kris-lab lgtm please let me know in https://github.com/cargomedia/puppet-cargomedia/issues/1702 when bipbip is deployed with sending header. The plan is to release socket-redis once clients are ready.

kris-lab commented 7 years ago

@tomaszdurka there are also tickets for puppet modules before we can continue. Please review them.

tomaszdurka commented 7 years ago

As wrote I think we should rather finish up clients first then. Sending the header makes no harm!

kris-lab commented 7 years ago

@tomaszdurka please have a look. I am gonna released this soon.

kris-lab commented 7 years ago

As implemented in socket-redis the status-secret is optional.