search

carla-simulator / carla

Open-source simulator for autonomous driving research.
http://carla.org
MIT License
11.53k stars 3.72k forks source link

Road._prevs gets pointer for road not specified in road._predecessor #2201

Closed ThrashAbaddon closed 4 years ago

ThrashAbaddon commented 5 years ago

Carla 0.9.6

In this xodr (uploaded as txt because github complains) we have

Road 1 (successor = 2)
* Lane 1 (successor 1)
* Lane 0
* Lane -1 (successor -1)

Road 2 (predecessor = 1)
* Lane 1 (predecessor 1)
* Lane 0
* Lane -1 (predecessor -1)

What happens here is that Road 1 gets pointer to Road 2 inside _prevs, and this isn't correct. Road 1 can only have pointer to Road 2 inside _nexts, which it does. I've looked at the test file for this part of the code test_opendrive.cpp and it seems there is only assert that none of the pointers is nullptr and nothing about is this correct referencing of previous and next roads (and lanes). two_roads.txt

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.