carlos-sarmiento / ha-iconset-generator

Generated FontAwesome icons for Home Assistant
3 stars 0 forks source link

JS Syntaxe #2

Closed Robvred closed 3 years ago

Robvred commented 3 years ago

Hello,

A small syntax error in the custom configuration code:

{ "outputPath": "js/v5-pro", // Where should the generated JS files be written. "iconsets": [ // An Array of iconsets to generate. { "directory": "icons/v5-pro/brands", // The path in which the .svg files can be found "name": "fab" // The name of the generated iconset. Used both for the js file and the ha prefix }, ] }

Instead of : { "outputPath": "js/v5-pro", // Where should the generated JS files be written. "iconsets": [ // An Array of iconsets to generate. { "directory": "icons/v5-pro/brands", // The path in which the .svg files can be found "name": "fab" // The name of the generated iconset. Used both for the js file and the ha prefix } ] }

Unexpected comma at ' },'

Thanks for this perfect solution ! 👍

carlos-sarmiento commented 3 years ago

Thanks for reporting, but I don't see that comma on the full conf file. It looks like it was modified locally and the comma was not removed there.

Robvred commented 3 years ago

Hello @carlos-sarmiento,

I was not really precise, the typo is in the Readme.md file

Capture d’écran 2021-01-24 à 19 59 48
carlos-sarmiento commented 3 years ago

Thanks for reporting. It is fixed.