search

carloscuesta / gitmoji

An emoji guide for your commit messages. 😜
https://gitmoji.dev
MIT License
15.66k stars 800 forks source link

Add dark mode support #541

Closed Jiab77 closed 4 years ago

Jiab77 commented 4 years ago

Hello @carloscuesta :sunglasses:!

Not a real issue but it would be nice to have a dark mode support while browsing the page in the night 😜

Got a "forced dark mode" bookmarklet but this kills the image colors as you can see:

image

vhoyer commented 4 years ago

see https://github.com/carloscuesta/gitmoji/pull/423

KaKi87 commented 4 years ago

PS @Jiab77 try Dark Reader, the dynamic filter preserves pics and emoji colors.

johannchopin commented 4 years ago

see https://github.com/carloscuesta/gitmoji/pull/423

KaKi87 commented 4 years ago

I know, I was just giving him a tip to improve force-dark features on non-dark websites in general.

Jiab77 commented 4 years ago

thank you all for your answers! I prefer not using a third party extension just for this usage. even if the suggested extension does not seem evil, it will still give the risk to share browsing history to a third party... I prefer avoid that.

in fact I was just thinking to a dark mode option added into the top right menu 😅

johannchopin commented 4 years ago

@Jiab77 Yep it would be better to provide it as a feature of the website and #423 is the first step of it 😉

KaKi87 commented 4 years ago

Yes indeed, I was only talking about all websites in general here. @Jiab77 Dark Reader is open source ;)