carlosqueiroz / dicompyler

Automatically exported from code.google.com/p/dicompyler
0 stars 0 forks source link

Unexpected display order of structures #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open a folder containing a structure set with many ROIs.
2. Have a look at the list of structures displayed at the left.
3. The structures appear in an unexpected order

What is the expected output? What do you see instead?
The expectation is that the structures are listed according to either the order 
in which they are read in the dicom file, or the order of their ROI number (in 
my case, and I guess in most cases, these two orders are the same).
Instead of this order, the structures seems to be displayed in a different 
order that I can't quite figure out. It doesnt seem to be totally random, as 
most of my structures are somewhat ordered. Actually, when looking at it again, 
I suspect that you are sorting by ROI Number (string) instead of ROI Number 
(integer). In my case, the ROI with number 128 gets displayed before the ROI 
with number 19. I guess this issue is not something you will discover unless 
you have a whole lot of ROIs, like in my case.

What version of the product are you using? On what operating system?
Dicompyler 0.4.1.1.exe

By the way, very excited about this new release!
Thanks for your effort on this dicom viewer!

Best regards,
Chris

Please provide any additional information below.

Original issue reported on code.google.com by chris.le...@gmail.com on 3 Jan 2012 at 10:17

Attachments:

GoogleCodeExporter commented 9 years ago
I am seeing that the numbers are stored as integer strings (IS) and are being 
returned as integers via pydicom. The structure list just iterates through a 
dictionary of structures, but I know that Python does not guarantee that the 
order of the keys returned in a dictionary iteration are sorted.

Therefore, I am committing a patch that will sort the keys (structure numbers), 
which should alleviate this issue. I tested with a structure set that I have 
that has 30 structures and found no difference, so I assume that the change 
should fix this issue.

Original comment by bastula on 14 Mar 2012 at 6:12

GoogleCodeExporter commented 9 years ago
This issue was closed by revision d707a03ac33e.

Original comment by bastula on 14 Mar 2012 at 6:21