search

carlsednaoui / ouibounce

Increase your landing page conversion rates.
MIT License
2.31k stars 373 forks source link

On fire() function, add display:flex #113

Closed paulhalfpenny closed 4 years ago

paulhalfpenny commented 8 years ago

I'm using display:flex to position my modal centrally on the page, but this is overriden by this function:

function fire() { // You can use ouibounce without passing an element // https://github.com/carlsednaoui/ouibounce/issues/30 if (el) el.style.display = 'block'; disable(); }

If you can change this line to: 

if (el) el.style.display = 'block | flex';

it works fine. I don't use Github typically, so no PR, but thought I would highlight it so you could add it in if you have time (or a better way of implementing this change!).

Kalabasa commented 5 years ago

I think a better way is to use visibility so clients can use any display style they want.