caronc / nzb-subliminal

Fetches subtitles for the videos it's provided. It can be easily integrated into NZBGet and SABnzbd too.
GNU General Public License v3.0
103 stars 14 forks source link

Standalone #49

Closed JackDandy closed 6 years ago

JackDandy commented 6 years ago

Hello again,

This project neatly wraps subliminal and addresses issues you found, and you are also adding auth.

One issue i see is the reliance (in cmdline mode) of a folder to scan, that data can actually not be available if 3rd-party-app has cleaned/renamed it -- however, the original names could still be available via the 3rd-party-app db, therefore, a method to simply send an original name would be useful.

Also, I guess the app saves the state of its decisions in order to act on them at some later time, it would be useful if this state list/object could be returned for saving elsewhere and then that data pushed back to your app at a later time. This implies a "try_again_in_mins" be returned so that 3rd-party-app know when at least to schedule a next call to your app. And this way, the data to be saved on whatever device is optionally managed by 3rd-party-app instead of yours.

Given that goals of this project can be enjoyed outside of NZBGET/SAB, then this project is suited to go through the same as Apprise, no?

JD

caronc commented 6 years ago

Given that goals of this project can be enjoyed outside of NZBGET/SAB, then this project is suited to go through the same as Apprise, no?

Subliminal is not my design at all. It's based on a very old fork of this project which pretty much handles your request (i think) - Standalone. The original developer has completely re-factored all of his old code (which i'm using).

The script as is does already track the age of the file(s) it's scanning against... so if you set up a cron to just run against your library say... every X minutes (like you're eluding to):

JackDandy commented 6 years ago

Yup, I know the origins of Subliminal. Your wrapper (i.e. app) is what holds value due to the issues in your tracker that you addressed to squeeze the best from upstream code.

Ok, I will look deeper, maybe I missed things that would allow me to run your script from another thread and allow me to inject a filename basestring instead of having your script use the filesystem which is redundant in my use case.

Thank you.