carpentries-incubator / python-intermediate-development

"Intermediate Research Software Development Skills (Python)" Lesson Material
https://carpentries-incubator.github.io/python-intermediate-development/
Other
52 stars 62 forks source link

Challenge 'Refactoring To Use a Pure Function' does not use solution implementation from previous challenge #394

Open svenvanderburg opened 1 month ago

svenvanderburg commented 1 month ago

In episode 3.4 we introduce a class-based solution for loading in csv files in analyse_data(): https://carpentries-incubator.github.io/python-intermediate-development/33-code-decoupling-abstractions/index.html#solution-1

In the later solution we still use the old implementation, whereas students at that point will have the class-based implementation of analyse_date() https://carpentries-incubator.github.io/python-intermediate-development/34-code-refactoring/index.html#exercise-refactoring-to-use-a-pure-function

svenvanderburg commented 1 week ago

Proposed fix: https://github.com/esciencecenter-digital-skills/python-intermediate-development-gitlab/pull/8/commits/9a1bbec1bb1ba42ed0bae3499be3ca6d8c1aeed0

In addition: https://github.com/esciencecenter-digital-skills/python-intermediate-development-gitlab/pull/8/commits/8020659c983947c150dfcfb98fbfb24f485eb8c4 to also make 'Exercise: Write Regression Tests' to use the mocked data source