search

carpentries-incubator / python-packaging-publishing

Packaging and Publishing with Python
https://carpentries-incubator.github.io/python-packaging-publishing/
Other
24 stars 16 forks source link

Exclude vendor dir from Jekyll build process. #67

Closed willfurnass closed 4 years ago

willfurnass commented 4 years ago

Without this the site can't be built using 'bundle exec jekyll build' ("Document 'vendor/bundle/ruby/2.5.0/gems/jekyll-3.8.5/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb' does not have a valid date in the YAML front matter.")

brownsarahm commented 4 years ago

Thanks! I was able to build offline, but I'm not sure if I have some weird setting my local jekyll.

Where is the vendor directory?

Also, in general, the latter part of config.yml is standard across lessons, so I'm flagging @fmichonneau to see if this might be a common problem with the template?

fmichonneau commented 4 years ago

yes, I've seen this a few times but I don't think that has ever been with our lessons (and so I haven't investigated the root of the issue). I don't think it'd hurt to add this to the _config.yml template file https://github.com/carpentries/styles/blob/gh-pages/bin/boilerplate/_config.yml though!

brownsarahm commented 4 years ago

Thanks @fmichonneau, I went to add it to styles and it's already there. I've merged this, but is there a way that lessons that use the remote theme get updates to files like config.yml?