search

carpentries / varnish

Template for pkgdown site
https://carpentries.github.io/varnish/
Other
7 stars 25 forks source link

Title card "Questions" wraps at high screen widths. #111

Closed Robadob closed 8 months ago

Robadob commented 9 months ago

https://github.com/carpentries/varnish/blob/2e62ad20e88748869b0259a300013cd1ffff32af/source/stylesheets/overview.scss#L42

The above line of code leads to the s of "Questions" wrapping within the "Overview" box when the screen width exceeds ~1645px (in Google Chrome).

This appears to be because the .container has a max width of 1209px, however the font size continues scaling beyond this point.

Note: it only occurs when the sidebar is expanded, as this reduces the overview box's width.

image

This episode built with varnish 0.4.0 is unaffected, it has a static font-size of 24px.

I've only got a broken version built locally, but appears to be 25.29px font-size when the wrapping first occurs.

zkamvar commented 9 months ago

Ooof yeah, thank you for pointing this out and for implementing a fix!

It looks like our attempt at #109 failed. I will check #112 on Monday and I believe we can release on Wednesday.