Change version constant naming pattern - Githubissues

carrierwaveuploader / carrierwave

Classier solution for file uploads for Rails, Sinatra and other Ruby web frameworks

https://github.com/carrierwaveuploader/carrierwave

8.78k stars 1.66k forks source link

Change version constant naming pattern #2748

Closed r7kamura closed 3 months ago

r7kamura commented 3 months ago

Because of the restriction that Ruby constant names must always begin with [A-Z], it would be desirable to make sure that this restriction is satisfied when naming dynamic constants.

Fix https://github.com/carrierwaveuploader/carrierwave/issues/2722

It was implemented well in carrierwave v2, but when object_id was removed from the constant name at https://github.com/carrierwaveuploader/carrierwave/commit/a9de7565eabb4cdca05bb090cdf797eb1720c09c, Uploader prefix was also removed at the same time for some reason.

mshibuya commented 3 months ago

Ah I didn't realize this point. Thank you so much!