Working deployers

[hhsnopek]

List of current deployers that work, edit as needed.

• [ ] dropbox
• [ ] ftp
• [x] gh-pages
• [x] heroku
• [ ] nodejitsu
• [x] s3
• [ ] vps
• [ ] email

Completed Tests for deployer

• [x] dropbox
• [ ] ftp
• [ ] gh-pages
• [ ] heroku
• [ ] nodejitsu
• [x] s3
• [ ] vps
• [ ] email

[jescalan]

Heroku and github pages still need tests to be entirely complete, but they are working

[hhsnopek]

s3 has working tests?

[kylemac]

Dropbox works, but can't effectively be tested because it requires us to pop open a browser and manually click. I attempted to automate this with zombie.js but it did not allow it.

So basically, it works but in a very unideal form. That being the case, it's kind of a step-child in these list of deployers since they don't allow serving directly from dropbox anyways.

[jescalan]

yes, s3's tests are passing and it is in use in production at carrot

[hhsnopek]

@kylemac is it possible to save the key for re-auth for the dropbox deployer or does it need to be re-auth every deploy? @jenius :+1:

[kylemac]

@HHSnopek yeah, that is in place on the dropbox branch.

https://github.com/carrot/ship/blob/dropbox/lib/deployers/dropbox/index.coffee#L117

edit: you'll notice a destroy() function, but that is just for the test

[hhsnopek]

@kylemac But when you deploy after your initial deploy do you still need to manually auth within the browser?

[kylemac]

@HHSnopek nope, if access_token is in the shipfile then it won't be removed. so either you add it manually or by going through that clunky click flow, it will write to the shipfile and never need to be written again. this presumes the access_token won't expire.

[hhsnopek]

@kylemac not to bad then, is it set to merge then, if so merge! :grinning:

[kylemac]

the biggest hurdle right now is the conflicts caused when I rebase the dropbox branch over master. I'm going to need to work through the conflicts with @jenius. maybe @jenius will be willing to take a look on his own. :grin:

[jescalan]

oh yeah i can check that out if you want, i'll get to this in the next day or 2

[kylemac]

great, please add this to your list. all we really need to do is get this branch up-to-date and for you to verify if it's in a place to be merged. I have to imagine there's some work on my promises that needs optimizaiton.

[kylemac]

archiving this for now, but I'll basically duplicate it later on since we hit the reset button a bit.