carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

Add branch argument to gh-pages deployer #21

Closed kylemac closed 10 years ago

kylemac commented 10 years ago

h/t to @nporteschaikin pointing this out.

project pages deploy from gh-pages branch and personal pages deploy from master so we'll need to make this more generic and accept a branch argument, but default to gh-pages. This could easily be set in the shipfile.conf

boo me for hardcoding this in the first place - https://github.com/carrot/ship/blob/master/lib/deployers/gh-pages/index.coffee#L51

jescalan commented 10 years ago

Good catch - this shouldn't be too tough to pull out though now that we know. We can just have the default be gh-pages unless you configure it to be master :grinning: