carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

add CSON support for config files #31

Closed notslang closed 10 years ago

samccone commented 10 years ago

:+1:

this has been talked about a tiny bit before as well https://github.com/jenius/roots/search?q=CSON&ref=cmdform&type=Issues

jescalan commented 10 years ago

Any particular reason for this?

notslang commented 10 years ago

CSON is pretty and easier to write than JSON? This isn't really an important issue, it's just something that I'm planning on adding cause it's a simple & useful feature.

jescalan commented 10 years ago

We don't use json right now though...

notslang commented 10 years ago

Actually that was part of the switch to jsonschema for validation. I'll add YAML back if people want it, but for now JSON is much easier to work with.

jescalan commented 10 years ago

Definitely would rather have yaml for a config file than json. You can just parse the yaml into json anyway :grinning:

notslang commented 10 years ago

cool, I'll add YAML too

samccone commented 10 years ago

I like CSON / YAML / js with a module.exports pattern / JSON

jescalan commented 10 years ago

We don't need module.exports for a shipfile config. I feel like if you are trying to execute js in a shipfile you are doing it so wrong that it shouldn't even be allowed. This is not like app.coffee in roots, this is purely config.

samccone commented 10 years ago

config can be dynamic tho depending on ENV ... I think that is super valuable

jescalan commented 10 years ago

We have different shipfiles for different environments

kylemac commented 10 years ago

There's also a JS API for any other fancy programmatic stuff someone might want to do - this is strictly for configuration for the CLI