carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

Github Pages Deployer #39

Closed jescalan closed 10 years ago

jescalan commented 10 years ago

So this is a github pages deployer that doesn't depend on git. It's pretty fast too.

jescalan commented 10 years ago

Ok sweet, this is working correctly! A couple more things I'd like to test/verify/think about:

Ignores

Since this deployer doesn't actually use git, .gitignore files are not adhered to, although you still can ignore files by passing patterns through the ignore param as is the case with any other deployer. There isn't a node library to parse the globstar patterns in the same way as git does with gitignores, as far as I'm aware, and minimatch works slightly differently, so while we could pull in .gitignore and add it automatically to the ignores array, this might produce some inconsistencies. Any thoughts on how this should be handled are welcome.

Error Handling, Test Cases

Things to Think About