Heroku Deployer - Githubissues

carrot / ship

⛔️ currently unmaintained ⛔️

Other

151 stars 14 forks source link

Heroku Deployer #40

Closed jescalan closed 10 years ago

jescalan commented 10 years ago

Ok so the heroku deployer is fully functional, which is awesome. It still needs a bit more cleanup in a few spots before I'm ready to merge the code though.

Methods and args in the deployer need to be cleaned up and some pieces need to be abstracted
Test should verify each of the progress calls
Archive should be gzipped in addition to tar
Potentially test the heroku edge api streaming build status functionality

jescalan commented 10 years ago

Ok sweet, so we are now using the edge api for streaming build output, which is working nicely. This deployer is fairly stable at this point, the only addition left that I'd like to make is gzipping, which I'll try to get in before merge. In the meantime, I'm going to sink a bit of time into making sure I can get tests passing on travis.