carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

Add custom conf dir option and fallback shipfile location to current working directory #52

Closed joshrowley closed 10 years ago

joshrowley commented 10 years ago

Okay, so I think the majority of the time, your ship.conf file isn't going to be located inside of the directory you are deploying since you wouldn't want to expose the contents of that file. However, right now ship only looks for the conf file inside of the folder being deployed.

This PR adds the following behavior:

jescalan commented 10 years ago

Hmm yeah I agree on the third point that it should write into cwd. Most deployers refuse to push a shipfile by auto-adding it to ignores so I think it should be safe.

joshrowley commented 10 years ago

Cool, I updated it to write to cwd. I didn't realize the shipfile ignore was set on a per deployer basis, would it be a good idea to set this globally like this, instead of within each deployer?

jescalan commented 10 years ago

@joshrowley yeah that seems like a good fix!

joshrowley commented 10 years ago

@jenius Does this PR look good for a merge? The only failing test is the broken heroku deployer.

jescalan commented 10 years ago

Yup!