search

carrot / ship

⛔️ currently unmaintained ⛔️
Other
151 stars 14 forks source link

Unexpected Token E #57

Closed mhartington closed 10 years ago

mhartington commented 10 years ago

So https://github.com/carrot/ship/commit/eb396de5ab8106a0a11af67d5afc6c7c688fb4d7 fixed my initial deployment issue, path must be a string, but it seems that there is still something else going on.

Maybe coming from some stuff missing in the documentation and not a real issue (which is very possible). Can to clarify on this?

$ ship public -to gh-pages

[?] username: mhartington
[?] password: xxxxxx
[?] repo: mike-blog
✘ SyntaxError: Unexpected token E
samccone commented 10 years ago

yeah the repo needs to be

mhartington/mike-blog

this needs to be a better error, or... something

mhartington commented 10 years ago

Alright, but if I follow that pattern I get this error

✘ {"message":"Invalid request.\n\nExpected data to be of type \"string\"; value was: nil.","documentation_url":"https://developer.github.com/v3"}
samccone commented 10 years ago

does your repo have a gh-pages branch already? I am guessing not...this is also busted

related issue https://github.com/carrot/ship/issues/48

samccone commented 10 years ago

just push an empty branch or whatever and it will all work... so basically the gh-pages deployer is confusing as heck... also it recently stopped working for me with image blobs

so i reverted to a basic shell script until all of this can get figured out

mhartington commented 10 years ago

Ahh alright, didn't see that one. Okay, thanks for the heads up, gonna close this then

jescalan commented 10 years ago

I'm sorry about this guys, will be working on fixing this up today and early next week! Just have had a lot on my plate, but will make this happen.

samccone commented 10 years ago

no worries :heart: im trying to helpz

mhartington commented 10 years ago

no worries, @samccone's suggestion worked for me. Keep up the great work!

jescalan commented 10 years ago

You guys are the best :sparkling_heart: