Add ability to supply PACFile to pac_context_for_url

carsonyl / pypac

Find and use proxy auto-config (PAC) files with Python and Requests.

https://pypac.readthedocs.io

Apache License 2.0

71 stars 18 forks source link

Add ability to supply PACFile to pac_context_for_url #52

Closed alexrohvarger closed 3 years ago

alexrohvarger commented 4 years ago

This is my first public pull request. Was looking at this module for a project I'm working on and saw a capability that I would like to have - imagine others may as well. I didn't add any additional tests - please let me know if I should add some.

coveralls commented 4 years ago

Coverage decreased (-0.4%) to 88.075% when pulling b73034a16d03be62e68962d179d8da59e01d941b on alexrohvarger:master into dc610a033b8c3754ca43e3fc2e3468815401d51b on carsonyl:master.

coveralls commented 4 years ago

Coverage remained the same at 88.494% when pulling 73f593417d6bf7e15683cea77e59dd446892c832 on alexrohvarger:master into dc610a033b8c3754ca43e3fc2e3468815401d51b on carsonyl:master.

carsonyl commented 3 years ago

Thanks for making this pull request. This looks good. Sorry for the delay in responding - it looks like I didn't get a notification.

I've moved the new pac kwarg to the end, in case people are supplying the proxy_auth kwarg by position.