search

casacore / casarest

The remainder of the AIPS++ libraries that did not end up on casacore
GNU General Public License v3.0
4 stars 12 forks source link

The OrderedMap and SimpleOrderedMap are now deprecated in casacore #26

Closed steve-ord closed 4 years ago

steve-ord commented 5 years ago

I'm having trouble building against casacore3.1 as the msvis component is using deprecated casacore classes. I don't want to force my users to use these as they do not need msvis. Is it possible to make some optional build targets. I could put together some edits to the cmake and submit a pull request?

gijzelaerr commented 5 years ago

hi @steve-ord , that would be great. Maybe autodetect against which casacore you are compiling?

gervandiepen commented 5 years ago

I've informed Malte about this change. It's already possible to specify -DBUILD_DEPRECATED=ON at cmake.

On Wed, May 22, 2019 at 2:51 PM Gijs Molenaar notifications@github.com wrote:

hi @steve-ord https://github.com/steve-ord , that would be great. Maybe autodetect against which casacore you are compiling?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/casacore/casarest/issues/26?email_source=notifications&email_token=AB34QPAVCCAXGMNFGI5RUMDPWU6VHA5CNFSM4HOT5NP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV66AEI#issuecomment-494788625, or mute the thread https://github.com/notifications/unsubscribe-auth/AB34QPCME76ZWVEHGSM4RDDPWU6VHANCNFSM4HOT5NPQ .

gervandiepen commented 5 years ago

Note that CASA has already changed all its code for this purpose. Do you use an old msvis?

On Wed, May 22, 2019 at 4:31 PM Ger van Diepen gervandiepen@gmail.com wrote:

I've informed Malte about this change. It's already possible to specify -DBUILD_DEPRECATED=ON at cmake.

On Wed, May 22, 2019 at 2:51 PM Gijs Molenaar notifications@github.com wrote:

hi @steve-ord https://github.com/steve-ord , that would be great. Maybe autodetect against which casacore you are compiling?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/casacore/casarest/issues/26?email_source=notifications&email_token=AB34QPAVCCAXGMNFGI5RUMDPWU6VHA5CNFSM4HOT5NP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV66AEI#issuecomment-494788625, or mute the thread https://github.com/notifications/unsubscribe-auth/AB34QPCME76ZWVEHGSM4RDDPWU6VHANCNFSM4HOT5NPQ .

tammojan commented 5 years ago

This is casarest, so a fork from an old casa.

steve-ord commented 5 years ago

I've tried the -DBUILD_DEPRECATED=ON and it is not sufficient - the files are now included in the build but the build stage of casarest/msvis still fails. I'll put together some more information today.

steve-ord commented 5 years ago

For example: If I build casacore with -DBUILD_DEPRECATED=ON then try to build casarest/msvis I still get the deprecated error.

Hmm maybe I just need to set AIPS_USE_DEPRECATED in the casarest build .... hang on.

gervandiepen commented 5 years ago

I've created casarest branch useSTL in which all old casacore classes such as Map have been replaced by their STL counterparts. Could you please try it out before we do the merge?

On Thu, May 23, 2019 at 2:56 AM Stephen Ord notifications@github.com wrote:

For example: If I build casacore with -DBUILD_DEPRECATED=ON then try to build casarest/msvis I still get the deprecated error.

Hmm maybe I just need to set AIPS_USE_DEPRECATED in the casarest build .... hang on.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/casacore/casarest/issues/26?email_source=notifications&email_token=AB34QPADSUMLOE55TYOERALPWXTSTA5CNFSM4HOT5NP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAYI3Q#issuecomment-495027310, or mute the thread https://github.com/notifications/unsubscribe-auth/AB34QPGJ2OSYDDMVIDPOLWTPWXTSTANCNFSM4HOT5NPQ .

tammojan commented 4 years ago

This should be fixed in the current master. I'll release a new version as well.