search

casact / chainladder-python

Actuarial reserving in Python
https://chainladder-python.readthedocs.io/en/latest/
Mozilla Public License 2.0
192 stars 71 forks source link

#294 and #313 are fixed here #373

Closed kennethshsu closed 2 years ago

jbogaardt commented 2 years ago

Just a little cleanup needed on this branch. import io and pull in latest changes to master.

kennethshsu commented 2 years ago

Yap just missed that. Thanks! Let me know if I missed anything else.

codecov-commenter commented 2 years ago

Codecov Report

Base: 83.29% // Head: 83.30% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (4a12443) compared to base (23f5da8). Patch coverage: 73.46% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #373 +/- ## ========================================== + Coverage 83.29% 83.30% +0.01% ========================================== Files 49 49 Lines 4250 4253 +3 Branches 709 710 +1 ========================================== + Hits 3540 3543 +3 Misses 508 508 Partials 202 202 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `83.30% <73.46%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/casact/chainladder-python/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [chainladder/utils/utility\_functions.py](https://codecov.io/gh/casact/chainladder-python/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvdXRpbHMvdXRpbGl0eV9mdW5jdGlvbnMucHk=) | `82.55% <0.00%> (ø)` | | | [chainladder/core/base.py](https://codecov.io/gh/casact/chainladder-python/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvY29yZS9iYXNlLnB5) | `80.99% <77.27%> (+0.23%)` | :arrow_up: | | [chainladder/core/triangle.py](https://codecov.io/gh/casact/chainladder-python/pull/373/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2hhaW5sYWRkZXIvY29yZS90cmlhbmdsZS5weQ==) | `89.13% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jbogaardt commented 2 years ago

Beautiful. Thanks @kennethshsu