casdoor / casdoor-java-sdk

Java client SDK for Casdoor
https://github.com/casdoor/casdoor
Apache License 2.0
27 stars 43 forks source link

Application Entity Missing Fields #86

Closed CameronMukherjee closed 2 months ago

CameronMukherjee commented 2 months ago

The Application entity found at org.casbin.casdoor.entity.Application is missing required fields that are needed to correctly load the OAuth2 page and admin dashboard.

Fields missing are:

Due to these missing fields the database is holding null. This results with a front-end error as the UI is expecting an array (even if it's an empty array) in comparison to null for both the OAuth2 login page, and the Admin Dashboard.

Snippet of subclasses that likely need to be added to the object:

public static class SignInMethod {

        public String name;
        public String displayName;
        public String rule;
    }
public static class SignInItem {

        public String name;
        public boolean visible;
        public String label;
        public String placeholder;
        public String rule;
        public boolean isCustom;
    }
public static class SignUpItem {

        public String label;
        public String name;
        public String placeholder;
        public boolean prompted;
        public String regex;
        public boolean required;
        public String rule;
        public boolean visible;
    }
casbin-bot commented 2 months ago

@tangyang9464 @JalinWang @imp2002

hsluoyz commented 2 months ago

@CameronMukherjee can you make a PR to add them?

CameronMukherjee commented 2 months ago

@CameronMukherjee can you make a PR to add them?

Sure, can I get permissions?

➜  casdoor-java-sdk git:(master) ✗ git checkout -b fix/86  
Switched to a new branch 'fix/86'
➜  casdoor-java-sdk git:(fix/86) ✗ gp
ERROR: Permission to casdoor/casdoor-java-sdk.git denied to CameronMukherjee.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
hsluoyz commented 2 months ago

You should create GitHub Pull Request, not directly commit to this repo, which is not allowed. Learn GitHub first

CameronMukherjee commented 2 months ago

You should create GitHub Pull Request, not directly commit to this repo, which is not allowed. Learn GitHub first

Sorry first time contributing to open source!