casework / CASE

Cyber-investigation Analysis Standard Expression (CASE) Ontology
https://caseontology.org
Apache License 2.0
65 stars 22 forks source link

Fix OWL syntax of CASE datatype #76

Closed ajnelson-nist closed 1 year ago

ajnelson-nist commented 2 years ago

This Pull Request was initially applied in the same manner as in this UCO commit in support of UCO CP-90: https://github.com/ucoProject/UCO/tree/242d315f9d0d838096c57b76f5d497a75dca0d13

It is now built upon PR 102.

Coordination

ajnelson-nist commented 2 years ago

Converting to Draft until Solutions Approval vote is logged.

ajnelson-nist commented 1 year ago

@plbt5 , @eoghanscasey - We have a conflict to resolve between Git mechanics and committee review.

UCO PR 427 was merged before the committee approval vote. This unfortunately means attempts to test the develop prerelease state (of CASE and UCO rolled together) now receive a flagging of CASE's one vocabulary in all pyshacl output. That will continue to be flagged until this PR is merged.

I request we merge this PR (CASE PR 76) into develop before the Solutions Approval vote Thursday. If the vote fails, we will revert the merge from develop.

If you both agree, please can the second of you to agree run the merge.

The consequences of not merging are:

  1. SHACL validation output against develop is cluttered with one message about CASE's vocabulary. This isn't too annoying to deal with.
  2. If the UCO pointer to develop gets bumped in CASE, CASE's CI will fail. This is more problematic, as it complicates most of the testing between now and Thursday, and there are still some significant changes I'm implementing and need to test.
eoghanscasey commented 1 year ago

@ajnelson-nist @plbt5 - I concur with the proposed approach.