cashapp / logquacious

Logquacious (lq) is a fast and simple log viewer.
Apache License 2.0
59 stars 14 forks source link

Fixes errors caused by unrecognized tags #167

Closed cpakman closed 2 years ago

cpakman commented 2 years ago

@jonwinton I can't add you as reviewer for some reason

So alternative here is to display the name with no title, but this also is fairly confusing (ie the issue occurs when we don't have a real label for a tag, so having no tag name but a description may be even more confusing)

example case if instead of e:cash-prod (e is our shorthand for env), we have e:production, right now the tag ui will crash. If we just display what we can, users will see Env: production as a tag, but get 0 results if we don't display anything, they will not see this tag at all, and get 0 results. If they look at the environment tabs in the top, none will be selected. I find this to be clearer than 'fake suggesting' that it's a non-existent cluster if the name of the environment doesn't match

This resolves SUPPORT-573 SUPPORT-659