search

cashapp / paparazzi

Render your Android screens without a physical device or emulator
https://cashapp.github.io/paparazzi/
Apache License 2.0
2.28k stars 214 forks source link

Differentiate similar and different pixels in delta image #1612

Open gabrielittner opened 1 week ago

gabrielittner commented 1 week ago

The OffByTwo differ is currently drawing similar pixels with the same rgb value as different pixels. This makes it hard to know which differences lead to a failure and which don't and can lead to developer confusion.

benwicks commented 4 days ago

What RGB value would you like to see in the delta image for similar pixels? @gabrielittner @jrodbx

Should similar pixels just be a static color (e.g. Red), or should they just be set to the expected color?

jrodbx commented 2 days ago

I'd go with similar pixels = blue? Red denotes an error, whereas similar here implies "passable".