search

cashshuffle / cashshuffle-electron-cash-plugin

Electron cash cash-shuffle plugin
27 stars 13 forks source link

Protocol does not terminate in the presence of malicious peers #26

Closed real-or-random closed 6 years ago

real-or-random commented 6 years ago

There are a lot of issues, e.g., peers can apparently can equivocate with their change address, or parse errors are not handled here: https://github.com/cashshuffle/cashshuffle-electron-cash-plugin/blob/bcd9d668dcde92649be78e445da5820ee79b7ffa/shuffle/coin_shuffle.py#L141

clifordsymack commented 6 years ago

This is not actual on current version of code. All messages coming into incoming channel parsed with exception catching here https://github.com/cashshuffle/cashshuffle-electron-cash-plugin/blob/master/shuffle/coin_shuffle.py#L125

If parsing goes well message go to inbox and other logic processed from it.