search

cashto / resistance

The Resistance Online
59 stars 51 forks source link

Removed blank line spamming #15

Closed JordanSekky closed 10 years ago

JordanSekky commented 10 years ago

Chat send command now checks to make sure the bar is not empty.

This is just a simple addition to the check for an enter keypress. It now also checks to make sure the message isn't blank. I don't have the sql server downloaded yet, so I can't test it out myself, but I don't see why this won't work.

cashto commented 10 years ago

I pushed this to prod but noticed an issue: when you're in a game and you hit enter, you get bounced out of the game into the lobby. Turns out that since we don't call event.preventDefault in this scenario, the browser goes on to route this as a click on the "exit to lobby" button.

I rolledback the changes but feel free to send another pull request (I know it's a simple fix, but I'm also using this as a chance to practice my git fu since I'm relatively new to git :-)

JordanSekky commented 10 years ago

Yeah, I'm new to it too. However it looks like you haven't actually rolled it back on the github site. Anyways, issue should be resolved, I added an elseif and submitted a new pull request.

cashto commented 10 years ago

Correct, I only rolled back what was deployed on production, I didn't reset master.

This next time I'm going to try it on the command line so I can test out the changes before pushing them to master.