casper-network / docs

Application running the documentation markdown files.
Apache License 2.0
25 stars 65 forks source link

Binary Serialization Standard #1478

Closed ACStone-MTS closed 3 months ago

ACStone-MTS commented 4 months ago

What does this PR fix/introduce?

This PR turns the "Serialization Standard" into the "Binary Serialization Standard" and splits it into multiple pages for ease of reading.

The document itself now includes all updated Condor types outside of the chainspec, which will be a separate PR.

Closes #1471 #1378

Additional context

// Add further detail on the current situation, or what the PR seeks to address. // Include loom, screenshots, or gifs(record, compress) if helpful.

Checklist

(Delete any that aren't relevant)

Reviewers

TBD

ACStone-MTS commented 4 months ago

@bradjohnl I'm getting a strange failure on the CICD for this one - could you take a look when you get a chance?

bradjohnl commented 4 months ago

@bradjohnl I'm getting a strange failure on the CICD for this one - could you take a look when you get a chance?

Hey @ACStoneCL . It's fixed. I've removed some hardcoded, and apparently redundant tests that were targeting pages that this PR removed / changed.

I've created an internal issue in our SRE board to check the testing strategy and make sure we are already testing each internal and external link with other processes (namely the: node check-external-urls.js test script).

ipopescu commented 4 months ago

I tried to help resolve a conflict, and then I had to fix a link for the build to pass.