search

castdrian / OSAC

The Open Source Audible Converter
GNU General Public License v2.0
74 stars 18 forks source link

paths with spaces don't work #12

Closed woldtwerk closed 5 years ago

woldtwerk commented 5 years ago

This is windows. Paths have spaces =) Pls add this feature

castdrian commented 5 years ago

This is answer. Paths with spaces are unhealthy and shouldn't be used ever. I can rename the file before conversion tho.

thw0rted commented 4 years ago

Can I make a suggestion? If you don't want to add quoting for filename arguments where required (understandable, since this can be a hassle), would you consider adding a check when selecting a file to show the user an error and suggest renaming to remove spaces? I had to figure this out by copy/pasting from the log window into Notepad and following the console output. If a user has less technical skill, they're likely to be stumped and wind up coming here to open another issue, or just looking for different software.

thw0rted commented 4 years ago

I noticed that when calling ffprobe, the argument is wrapped in double quotes, but when calling ffmpeg it is not. I think the error might be resolved if you wrap fileout in quotes. (ETA: would also be good to wrap inputdisplay.Text in quotes, in case the input file name/path have special characters.)

I don't have the build toolchain set up myself at the moment, so I can't actually test a PR, but if I have a little free time over the weekend I might give it a shot.