casualsnek / onthespot

qt based music downloader written in python
GNU General Public License v2.0
944 stars 79 forks source link

[BUG] 80-90% of files downloaded won't convert to mp3 and if download as ogg are corrupted and unabled to be used elsewhere #156

Open Arashisenko opened 2 months ago

Arashisenko commented 2 months ago

Describe the bug Downloading discographies, large chunks of it will hang at 90+% conversion. If RAW media is checked they will download, but in ogg format they will be corrupted (I was told no fileheader) making them unusable and unable to be converted to other usable formats.

To Reproduce Any use of GUI downloading individual songs, albums, artists or playlists results in this ~90% of time at default setting configuration with a premium account being used.

Screenshots Random file downloaded Screenshot_1

Errors given in programs like Foobar2k and Xrecode Screenshot_2

I've been told all ogg files should start with this in hex Screenshot_3

But instead I am getting things like this. I tried 5 random corrupted ogg files and they all started with different values. Screenshot_4

System Information (please complete the following information): Windows 11 build 22631.4169 Onthespot: can't seem to find the version number, was downloaded 8/11/24, whatever was the newest version at that time.

justin025 commented 2 months ago

Did you download onthespot_win.exe or onthespot_win_ffm.exe? It sounds like you downloaded the former you need ffmpeg installed or can download 'onthespot_win_ffm.exe' which comes with it bundled.

Arashisenko commented 2 months ago

Hi,

I did download onthespot_win_ffm.exe

justin025 commented 2 months ago

In my updated builds all of the files are tagged with mutagen instead of music tag (which is used in the original onthespot), you can try them and let me know if they work.

Latest Release: https://github.com/justin025/onthespot/releases/tag/v0.7.0 Latest Dev Build (couple new features): https://github.com/justin025/onthespot/releases/tag/dev

If they also don't work I would be interested to see your logs. Also send an album or track for me to test.

Arashisenko commented 2 months ago

Where do I find the logs? I just tried these and at least with the first entire artist I tried everything failed without ever downloading or converting. I'll try another couple albums to be safe after.

justin025 commented 2 months ago

%localappdata%/Temp/onthespot or C:\Users\USERNAME\AppData\Local\Temp\onthespot\logs

The logs do not include any personal information, my suggestion would be to send the whole folder as a zip file. If not you can run through the app a few times and send me the latest log file the app creates.

Also are you in the EU? I do know that by default some windows builds do not include media codecs by default, you can check this in settings. If this is the case your os will be labelled Windows 11 Pro N instead of Windows 11 Pro.

Arashisenko commented 2 months ago

I am in the US. Here is what is in the folder right now. I have been jumping around builds, trying all sorts of different bands/albums/songs for a while so there might be a lot. Thanks for all the help so far! logs.zip

justin025 commented 2 months ago

Isn't it quite late in the US lmao

The error in question is the following

  File "worker\downloader.py", line 139, in download_track
  File "<frozen os>", line 215, in makedirs
  File "<frozen os>", line 225, in makedirs
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'C:\\Users\\Admin\\Music\\OnTheSpot\\11 Acorn Lane'

Have you changed your advanced settings by chance, this does not look like the default download path (artist/album/song)? Does it download to mp3 on the default settings?

Arashisenko commented 2 months ago

I don't recall changing anything in advanced settings, certainly not a file path. If I go into advanced settings it has track format as mp3 if that is what you mean but I haven't been able to get anything to download in a long time, and last time I did it was only with the RAW media boxed checked which gave me (apparently corrupted) oggs but that was on a different version a while ago, and it stopped working but I am unclear as to why.

And yes, it is 0130 at time of writing, but I am an insomniac trained to work on even less sleep due a long career in emergency services. That being said I will probably be sleeping after this.

justin025 commented 2 months ago

A few things to consider,

  1. Does the app work on other computers, this would rule out a ratelimited spotify account.
  2. Does downloading episodes / podcasts work?
  3. Does the app work if you go to advanced settings and click reset settings?
  4. If you try changing the download directory to, for example, C:/Users/USERNAME/Music/test and sit inside that directory while downloading do you see the files downloading? The process should be download .songname.ogg > create songname.mp3 > delete .songname.ogg (Windows 11 hides file extensions and files starting with a . by default)

If all of the above do not work / seem fine then you could reach out to me on discord and I could take a better look over something like teamviewer, but no promises that I will fix the problem. @j075046

Arashisenko commented 2 months ago

I don't currently have access to another computer, but I vaguely recall it working on my old laptop a while ago. But I also tried using my wifes account in case the account was the issue and it still insta-failed everything. Tried a few podcasts, a window popped up saying it was parsing and 20 minutes later it's the download list is still blank. Next I did the "reset settings" when it reopened I had to repair my spotify account and it told me that it couldn't create a folder at c/users/admin/music/onthespot and closed. When I reopened it that seemed to be resolved but still insta failing downloads. Finally, I manually changed the directory to c/downloads. Still nothing. I'll reach out on discord after work.

Arashisenko commented 1 month ago

A few things to consider,

1. Does the app work on other computers, this would rule out a ratelimited spotify account.

If all of the above do not work / seem fine then you could reach out to me on discord and I could take a better look over something like teamviewer, but no promises that I will fix the problem. @j075046

Okay, I finally had access to another computer. Yours worked on that, so I guess now I would need to tried removing everything on my computer to try yours fresh. Any idea where all and what all I need to delete for a clean removal of the original so I can try yours and see if I can get that to work?

justin025 commented 1 month ago

The casualsnek version is installed at C:/Users/USERNAME/.config & .cache Mine is installed at %appdata%/onthespot. You can start by deleting those files and seeing if downloads are fixed.

Keep me updated

Arashisenko commented 1 month ago

i'll probably add you on Discord soon. Deleted everything, grabbed the newest exe from your page. Still failing instantly. Boo.