cat-in-136 / cargo-generate-rpm

Cargo helper command to generate a binary RPM package
MIT License
87 stars 19 forks source link

Output directory now used by target_file_name #91

Closed dsteeley closed 1 year ago

dsteeley commented 1 year ago

Fixup bug from clap migration where the target file name was determined using the target argument and the docs indicate that it should be determined using the output argument.

dsteeley commented 1 year ago

Fixes #90

juliusl commented 1 year ago

There's a bit of non-trivial logic going on here, could you extract this into a fn and add some unit tests?

dsteeley commented 1 year ago

There's a bit of non-trivial logic going on here, could you extract this into a fn and add some unit tests?

Done, added a test for each of the cases in that logic.

cat-in-136 commented 1 year ago

Thanks a lot.