search

catalinghita8 / android-compose-mvvm-foodies

Android sample app following best practices: Kotlin, Compose, Coroutines and Flow, Hilt, JetPack Navigation, ViewModel, MVVM, Retrofit, Coil
473 stars 89 forks source link

Dark theme background color #5

Closed wiryadev closed 3 years ago

wiryadev commented 3 years ago

There is a small issue with background color in dark theme becaus of usage of the same color for background both in dark and light pallete. See below image:

Home Detail
Screenshot_1625833685 Screenshot_1625833691
I changed the background color for dark pallete so it looks like this Home Detail
Screenshot_1625833801 Screenshot_1625833822

Are you fine with this? If so i will open new request.

catalinghita8 commented 3 years ago

It looks fine. I have overlooked the dark theming, thanks.

Please open a PR and I will have a look into the code as well.

wiryadev commented 3 years ago

It looks fine. I have overlooked the dark theming, thanks.

Please open a PR and I will have a look into the code as well.

no problem, thanks for this great learning resource. I opened it here