Fix unit tests in auth_plugin_test.php

catalyst / moodle-auth_userkey

Log in to Moodle using one time user key based login URL. Auth plugin for organising simple SSO (single sign on) between moodle and your external web application.

https://moodle.org/plugins/auth_userkey

83 stars 53 forks source link

Fix unit tests in auth_plugin_test.php #101

Closed wo14580 closed 11 months ago

wo14580 commented 12 months ago

Related to this issue issue 97, a first fix was done by replacing PARAM_URL by PARAM_LOCALURL (commit)

Some of the unit tests were broken because of the entire url redirection. In this PR I replaced the redirection to google by a local redirection.

To test it: vendor/bin/phpunit auth/userkey/tests/auth_plugin_test.php

danmarsden commented 12 months ago

@dmitriim - looks like github actions caught this but the actions config "skipped" a subsequent run and so reported a succesful "skip" rather than a succesful run?

dmitriim commented 12 months ago

yeah. Looks like I missed that. Thanks @wo14580 for providing a fix.