search

catalyst / moodle-auth_userkey

Log in to Moodle using one time user key based login URL. Auth plugin for organising simple SSO (single sign on) between moodle and your external web application.
https://moodle.org/plugins/auth_userkey
83 stars 53 forks source link

Fix for when the key IP has been incorrectly set to be that of a proxy #30

Closed andrewhancox closed 6 years ago

dmitriim commented 6 years ago

@andrewhancox looks like you have a lot of fun using this plugin :+1: Could you please provide a bit more background on this issue. I'm not really sure that I can understand what's happening in the code.

dmitriim commented 6 years ago

Hi @andrewhancox Hope you are well. Any plans to continue working on this pull request?

andrewhancox commented 6 years ago

To be honest, I've now disabled this security feature as I had a steady drip of users who it didn't quite work for. There were a couple of cases where, for absolutely no reason I could see (no proxy/nat/etc. between the user and either of the systems) the connections came from different IPs - I think it MAY have been users going out through a load balanced connection but won't ever be able to find out.

dmitriim commented 6 years ago

@andrewhancox not a problem. I'll close this pull request then.