search

catalyst / moodle-tool_excimer

A Moodle tool to find bottlenecks in your code safely in production
https://moodle.org/plugins/tool_excimer
GNU General Public License v3.0
13 stars 9 forks source link

Hooks Callback warnings causing failures #370

Open sumaiyamannan opened 4 weeks ago

sumaiyamannan commented 4 weeks ago

Hi, On Moodle 4.5 the callback after_config leads to the below issue 

Callback after_config in tool_excimer component should be migrated to new hook callback for core\hook\after_config

The fix for it is here https://github.com/sumaiyamannan/moodle-tool_excimer/commit/bf040db7d352c4152911e5075b017b000981535c

But we need to add it in a new branch as it might have issues in older versions of Moodle

Regards, Sumaiya

danmarsden commented 4 weeks ago

Thanks @sumaiyamannan - as mentioned internally, if you get a chance to push through a PR that includes a change to version.php that increases the required version to 4.5 we can create a new branch and merge that in.

sumaiyamannan commented 3 weeks ago

Here it is. I have bumped the version number as well to highlight the difference, I hope this that is fine. https://github.com/catalyst/moodle-tool_excimer/pull/371