Align email page controls with manager

catalyst / moodle-tool_mfa

A Multi-Factor Authentication Moodle plugin with flexible support for TOTP, Email, IP and more

https://moodle.org/plugins/tool_mfa

34 stars 38 forks source link

Align email page controls with manager #415

Closed Peterburnett closed 1 year ago

danmarsden commented 1 year ago

will you drop in a PR for the latest 400_STABLE branch before we merge this into the older 35_STABLE one?

Peterburnett commented 1 year ago

@danmarsden I planned to just cherry-pick it across once merged

danmarsden commented 1 year ago

It's pretty bad practice.... new code should always land in the latest branch first and then be cherry-picked to older branches IMO.

Peterburnett commented 1 year ago

Sure. the comments reminded me that we are on a new branch structure now anyway, I mostly forgot when I wrote this last night. Ill PR it against the top level and get that merged, then revisit here. Not too worried as the branches are so well aligned right now, but no reason not to order it correctly