search

catalyst / moodle-tool_webanalytics

A Moodle admin tool adding Web Analytics to your Moodle site.
https://moodle.org/plugins/tool_webanalytics
7 stars 10 forks source link

Fix issue #39 #41

Closed dmitriim closed 3 years ago

brendanheywood commented 3 years ago

This all looks good, the only question is wether this should land in master or we move this plugin to the new stable branch names

dmitriim commented 3 years ago

Do you see anything that could be broken? It's mostly refactoring for the code. There shouldn't be any breaking changes. I have CI for 3.5, 3.9, 3.10 and 3.11. Unfortunately it doesn't check a lot. At least the plugin can be installed. :) I can add more tests to make sure it's not broken for 3.5

brendanheywood commented 3 years ago

My main concern would be totara 11

dmitriim commented 3 years ago

ah! very good point. Will create a branch for totara.

dmitriim commented 3 years ago

Actually I have checked and this plugin requires Moodle 3.3+. Means we don't run it in totara 11. It should work k for totara 12 though.

dmitriim commented 3 years ago

I have created https://github.com/catalyst/moodle-tool_webanalytics/issues/42